[Lldb-commits] [PATCH] D44738: Add a test for setting the load address of a module with differing physical/virtual addresses

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.
labath added a reviewer: owenpshaw.

First attempt at landing https://reviews.llvm.org/D42145 was reverted because it caused test
failures on some android devices. It turned out this was because these
devices had vdso modules with differing physical and virtual addresses.
This was not caught earlier because all of the modules in our tests
either lack physical addresses or have them identical to virtual ones.

In the discussion on the patch, we came to the conclusion that in the
scenario where we are merely setting a load address of a module (for
example from a dynamic loader plugin), we should always use virtual
addresses (i.e., preserve status quo). This patch adds a test to make
sure we don't regress in that direction.


https://reviews.llvm.org/D44738

Files:
  packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestGDBRemoteLoad.py


Index: packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestGDBRemoteLoad.py
===================================================================
--- packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestGDBRemoteLoad.py
+++ packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestGDBRemoteLoad.py
@@ -6,6 +6,25 @@
 
 class TestGDBRemoteLoad(GDBRemoteTestBase):
 
+    def setUp(self):
+        super(TestGDBRemoteLoad, self).setUp()
+        self._initial_platform = lldb.DBG.GetSelectedPlatform()
+
+    def tearDown(self):
+        lldb.DBG.SetSelectedPlatform(self._initial_platform)
+        super(TestGDBRemoteLoad, self).tearDown()
+
+    def test_module_load_address(self):
+        """Test that setting the load address of a module uses virtual addresses"""
+        target = self.createTarget("a.yaml")
+        process = self.connect(target)
+        module = target.GetModuleAtIndex(0)
+        self.assertTrue(module.IsValid())
+        self.assertTrue(target.SetModuleLoadAddress(module, 0).Success())
+        address = target.ResolveLoadAddress(0x2001)
+        self.assertTrue(address.IsValid())
+        self.assertEqual(".data", address.GetSection().GetName())
+
     def test_ram_load(self):
         """Test loading an object file to a target's ram"""
         target = self.createTarget("a.yaml")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44738.139299.patch
Type: text/x-patch
Size: 1362 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180321/69f2501b/attachment.bin>