[Lldb-commits] [PATCH] D44613: Support template template parameters

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2043
+    is_template_template_argument = true;
+    [[clang::fallthrough]];
   case DW_TAG_template_type_parameter:
----------------
Shouldn't we be using a #define so this works on any compiler?


================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2093
+      if (!is_template_template_argument) {
+        assert(clang_type && "AST context could not provide void type.");
         bool is_signed = false;
----------------
Do we really want to kill the program here? lldbassert would be better IMHO. Templates are one of the most contentious areas of the DWARF from compiler to compiler and I would rather we not crash when we can't successfully dig out a type from DWO/DWZ/type units/-gmodules etc...


https://reviews.llvm.org/D44613