[Lldb-commits] [PATCH] D44306: Move Args::StringToAddress to Target::EvaluateAddressExpression

[Zachary Turner via lldb-commits]

I think having all parsing functions in a single place will just move the
layering problem elsewhere, since a bunch of conversion functions for
objects from various libraries will be mushed together into one place.

On Wed, Mar 14, 2018 at 11:34 AM Jim Ingham via Phabricator <
reviews at reviews.llvm.org> wrote:

> jingham added a comment.
>
> Except for the to -> To to keep consistent with all the other lldb
> function naming this looks fine.
>
> Now that they are all together it's easy to see we haven't been consistent
> in these functions.  We really should make ToFormat return the format &
> take an error reference, and have ToBoolean take an error so callers don't
> have to cons it up.  But that's orthogonal to this patch.
>
>
>
> ================
> Comment at: include/lldb/Interpreter/OptionArgParser.h:18-19
> +struct OptionArgParser {
> +  static lldb::addr_t toAddress(const ExecutionContext *exe_ctx,
> +                                llvm::StringRef s, lldb::addr_t
> fail_value,
> +                                Status *error);
> ----------------
> Should be ToAddress.
>
>
> https://reviews.llvm.org/D44306
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180314/ed125263/attachment.html>