[Lldb-commits] [lldb] r327512 - [test] Disable TestMachCore everywhere except on Darwin

[Pavel Labath via lldb-commits]

Take a look at #ifdef __APPLE__ around ObjectFileMachO in
SystemInitializerCommon.cpp.

I tried removing that, but that led to a bunch of undefined symbol errors
(because of other stuff that was ifdefed out). It could be this is just a
matter of removing enough ifdefs, but I haven't tried following through on
that (so I don't know whether we'll run into some code including system
headers or such...).


On Wed, 14 Mar 2018 at 17:20, Greg Clayton via lldb-commits <
lldb-commits at lists.llvm.org> wrote:

> What part is ifdef'ed? Mach core files should be available on any platform?
>
> > On Mar 14, 2018, at 7:16 AM, Jonas Devlieghere via lldb-commits <
> lldb-commits at lists.llvm.org> wrote:
> >
> > Author: jdevlieghere
> > Date: Wed Mar 14 07:16:23 2018
> > New Revision: 327512
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=327512&view=rev
> > Log:
> > [test] Disable TestMachCore everywhere except on Darwin
> >
> > Apparently the parser is wrapped inside ifdef's so the logic isn't
> > available on non-Darwin platforms.
> >
> > Should fix build bot failure:
> >
> http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/20463
> >
> > Modified:
> >
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/mach-core/TestMachCore.py
> >
> > Modified:
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/mach-core/TestMachCore.py
> > URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/mach-core/TestMachCore.py?rev=327512&r1=327511&r2=327512&view=diff
> >
> ==============================================================================
> > ---
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/mach-core/TestMachCore.py
> (original)
> > +++
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/mach-core/TestMachCore.py
> Wed Mar 14 07:16:23 2018
> > @@ -26,6 +26,7 @@ class MachCoreTestCase(TestBase):
> >         lldb.DBG.SetSelectedPlatform(self._initial_platform)
> >         super(MachCoreTestCase, self).tearDown()
> >
> > +    @skipUnlessDarwin
> >     def test_selected_thread(self):
> >         """Test that the right thread is selected after a core is
> loaded."""
> >         # Create core form YAML.
> >
> >
> > _______________________________________________
> > lldb-commits mailing list
> > lldb-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180314/589e50e2/attachment-0001.html>