[Lldb-commits] [lldb] r327483 - Skip TestWatchedVarHitWhenInScope.py everywhere

[Pavel Labath via lldb-commits]

Author: labath
Date: Wed Mar 14 02:13:33 2018
New Revision: 327483

URL: http://llvm.org/viewvc/llvm-project?rev=327483&view=rev
Log:
Skip TestWatchedVarHitWhenInScope.py everywhere

The expression-hits tracking logic is not available on any platform. The
reason this tests happens to pass on some platforms is that the test is
written poorly -- it relies on the fact that post-main cleanup code will
write to the stack memory once occupied by the watched variable, but
this is not the case everywhere (e.g. linux glibc does not seem to do
this, but android's bionic library does).

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoint/variable_out_of_scope/TestWatchedVarHitWhenInScope.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoint/variable_out_of_scope/TestWatchedVarHitWhenInScope.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoint/variable_out_of_scope/TestWatchedVarHitWhenInScope.py?rev=327483&r1=327482&r2=327483&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoint/variable_out_of_scope/TestWatchedVarHitWhenInScope.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoint/variable_out_of_scope/TestWatchedVarHitWhenInScope.py Wed Mar 14 02:13:33 2018
@@ -23,8 +23,6 @@ class WatchedVariableHitWhenInScopeTestC
     # but the way this was done was incorrect, and it is unclear that for the
     # most part that's not what folks mostly want, so we have to provide a
     # clearer API to express this.
-    #
-    # This functionality is currently unsupported on Darwin.
 
     def setUp(self):
         # Call super's setUp().
@@ -36,7 +34,7 @@ class WatchedVariableHitWhenInScopeTestC
 
     # Test hangs due to a kernel bug, see fdfeff0f in the linux kernel for details
     @skipIfTargetAndroid(api_levels=list(range(25+1)), archs=["aarch64", "arm"])
-    @skipIfDarwin
+    @skipIf
     def test_watched_var_should_only_hit_when_in_scope(self):
         """Test that a variable watchpoint should only hit when in scope."""
         self.build(dictionary=self.d)