[Lldb-commits] [lldb] r327463 - [test] Replace some references to Apple-internal bugs
Vedant Kumar via lldb-commits
lldb-commits at lists.llvm.org
Tue Mar 13 16:37:11 PDT 2018
Author: vedantk
Date: Tue Mar 13 16:37:11 2018
New Revision: 327463
URL: http://llvm.org/viewvc/llvm-project?rev=327463&view=rev
Log:
[test] Replace some references to Apple-internal bugs
This removes around 10 references to Apple-internal radars. I've filed
fresh bugs on bugs.llvm.org as appropriate for open issues.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/api/multiple-debuggers/TestMultipleDebuggers.py
lldb/trunk/packages/Python/lldbsuite/test/functionalities/asan/TestReportData.py
lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoint/variable_out_of_scope/TestWatchedVarHitWhenInScope.py
lldb/trunk/packages/Python/lldbsuite/test/lang/c/shared_lib/TestSharedLib.py
lldb/trunk/packages/Python/lldbsuite/test/lang/c/shared_lib_stripped_symbols/TestSharedLibStrippedSymbols.py
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/dynamic-value/TestCppValueCast.py
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/printf/TestPrintf.py
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/stl/TestSTL.py
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/unique-types/TestUniqueTypes.py
lldb/trunk/packages/Python/lldbsuite/test/lang/objc/bitfield_ivars/TestBitfieldIvars.py
Modified: lldb/trunk/packages/Python/lldbsuite/test/api/multiple-debuggers/TestMultipleDebuggers.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/api/multiple-debuggers/TestMultipleDebuggers.py?rev=327463&r1=327462&r2=327463&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/api/multiple-debuggers/TestMultipleDebuggers.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/api/multiple-debuggers/TestMultipleDebuggers.py Tue Mar 13 16:37:11 2018
@@ -18,17 +18,9 @@ class TestMultipleSimultaneousDebuggers(
mydir = TestBase.compute_mydir(__file__)
+ # This test case fails non-deterministically.
@skipIfNoSBHeaders
- @expectedFailureAll(bugnumber="rdar://30564102")
- @expectedFailureAll(
- archs="i[3-6]86",
- bugnumber="multi-process-driver.cpp creates an x64 target")
- @expectedFailureAll(
- oslist=[
- "windows",
- "linux",
- "freebsd"],
- bugnumber="llvm.org/pr20282")
+ @expectedFailureAll(bugnumber="llvm.org/pr20282")
def test_multiple_debuggers(self):
env = {self.dylibPath: self.getLLDBLibraryEnvVal()}
Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/asan/TestReportData.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/asan/TestReportData.py?rev=327463&r1=327462&r2=327463&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/functionalities/asan/TestReportData.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/asan/TestReportData.py Tue Mar 13 16:37:11 2018
@@ -24,7 +24,7 @@ class AsanTestReportDataCase(TestBase):
@skipIfFreeBSD # llvm.org/pr21136 runtimes not yet available by default
@skipIfRemote
@skipUnlessAddressSanitizer
- @expectedFailureAll(archs=['i386'], bugnumber="rdar://28658860")
+ @skipIf(archs=['i386'], bugnumber="llvm.org/PR36710")
def test(self):
self.build()
self.asan_tests()
Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoint/variable_out_of_scope/TestWatchedVarHitWhenInScope.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoint/variable_out_of_scope/TestWatchedVarHitWhenInScope.py?rev=327463&r1=327462&r2=327463&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoint/variable_out_of_scope/TestWatchedVarHitWhenInScope.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoint/variable_out_of_scope/TestWatchedVarHitWhenInScope.py Tue Mar 13 16:37:11 2018
@@ -18,13 +18,13 @@ class WatchedVariableHitWhenInScopeTestC
mydir = TestBase.compute_mydir(__file__)
- #
# This test depends on not tracking watchpoint expression hits if we have
# left the watchpoint scope. We will provide such an ability at some point
# but the way this was done was incorrect, and it is unclear that for the
# most part that's not what folks mostly want, so we have to provide a
# clearer API to express this.
#
+ # This functionality is currently unsupported on Darwin.
def setUp(self):
# Call super's setUp().
@@ -36,7 +36,7 @@ class WatchedVariableHitWhenInScopeTestC
# Test hangs due to a kernel bug, see fdfeff0f in the linux kernel for details
@skipIfTargetAndroid(api_levels=list(range(25+1)), archs=["aarch64", "arm"])
- @unittest2.expectedFailure("rdar://problem/18685649")
+ @skipIfDarwin
def test_watched_var_should_only_hit_when_in_scope(self):
"""Test that a variable watchpoint should only hit when in scope."""
self.build(dictionary=self.d)
Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/shared_lib/TestSharedLib.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/c/shared_lib/TestSharedLib.py?rev=327463&r1=327462&r2=327463&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/lang/c/shared_lib/TestSharedLib.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/lang/c/shared_lib/TestSharedLib.py Tue Mar 13 16:37:11 2018
@@ -45,7 +45,7 @@ class SharedLibTestCase(TestBase):
"""Test that types work when defined in a shared library and forward-declared in the main executable, but with preloading disabled"""
self.common_test_expr(False)
- @unittest2.expectedFailure("rdar://problem/10704639")
+ @unittest2.expectedFailure("llvm.org/PR36712")
def test_frame_variable(self):
"""Test that types work when defined in a shared library and forward-declared in the main executable"""
self.build()
Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/shared_lib_stripped_symbols/TestSharedLibStrippedSymbols.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/c/shared_lib_stripped_symbols/TestSharedLibStrippedSymbols.py?rev=327463&r1=327462&r2=327463&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/lang/c/shared_lib_stripped_symbols/TestSharedLibStrippedSymbols.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/lang/c/shared_lib_stripped_symbols/TestSharedLibStrippedSymbols.py Tue Mar 13 16:37:11 2018
@@ -16,7 +16,7 @@ class SharedLibStrippedTestCase(TestBase
@expectedFailureAll(oslist=["windows"])
def test_expr(self):
- """Test that types work when defined in a shared library and forward-declared in the main executable"""
+ """Test that types work when defined in a shared library and forwa/d-declared in the main executable"""
if "clang" in self.getCompiler() and "3.4" in self.getCompilerVersion():
self.skipTest(
"llvm.org/pr16214 -- clang emits partial DWARF for structures referenced via typedef")
@@ -34,7 +34,7 @@ class SharedLibStrippedTestCase(TestBase
"other_element = 3"])
@expectedFailureAll(oslist=["windows"])
- @unittest2.expectedFailure("rdar://problem/10381325")
+ @unittest2.expectedFailure("llvm.org/PR36712")
def test_frame_variable(self):
"""Test that types work when defined in a shared library and forward-declared in the main executable"""
self.build()
Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/dynamic-value/TestCppValueCast.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/dynamic-value/TestCppValueCast.py?rev=327463&r1=327462&r2=327463&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/dynamic-value/TestCppValueCast.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/dynamic-value/TestCppValueCast.py Tue Mar 13 16:37:11 2018
@@ -19,8 +19,7 @@ class CppValueCastTestCase(TestBase):
mydir = TestBase.compute_mydir(__file__)
- @unittest2.expectedFailure(
- "rdar://problem/10808472 SBValue::Cast test case is failing (virtual inheritance)")
+ @skipIf(bugnumber="llvm.org/PR36714")
@add_test_categories(['pyapi'])
def test_value_cast_with_virtual_inheritance(self):
"""Test SBValue::Cast(SBType) API for C++ types with virtual inheritance."""
Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/printf/TestPrintf.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/printf/TestPrintf.py?rev=327463&r1=327462&r2=327463&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/printf/TestPrintf.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/printf/TestPrintf.py Tue Mar 13 16:37:11 2018
@@ -4,4 +4,4 @@ from lldbsuite.test import decorators
lldbinline.MakeInlineTest(
__file__, globals(), [
decorators.expectedFailureAll(
- bugnumber="rdar://problem/24599697")])
+ bugnumber="llvm.org/PR36715")])
Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/stl/TestSTL.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/stl/TestSTL.py?rev=327463&r1=327462&r2=327463&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/stl/TestSTL.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/stl/TestSTL.py Tue Mar 13 16:37:11 2018
@@ -26,7 +26,7 @@ class STLTestCase(TestBase):
self.line = line_number(
self.source, '// Set break point at this line.')
- @expectedFailureAll(bugnumber="rdar://problem/10400981")
+ @expectedFailureAll(bugnumber="llvm.org/PR36713")
def test(self):
"""Test some expressions involving STL data types."""
self.build()
@@ -38,9 +38,6 @@ class STLTestCase(TestBase):
self.runCmd("file " + exe, CURRENT_EXECUTABLE_SET)
- # rdar://problem/8543077
- # test/stl: clang built binaries results in the breakpoint locations = 3,
- # is this a problem with clang generated debug info?
lldbutil.run_break_set_by_file_and_line(
self, "main.cpp", self.line, num_expected_locations=1, loc_exact=True)
@@ -60,8 +57,6 @@ class STLTestCase(TestBase):
self.runCmd(
'expr for (int i = 0; i < hello_world.length(); ++i) { (void)printf("%c\\n", hello_world[i]); }')
- # rdar://problem/10373783
- # rdar://problem/10400981
self.expect('expr associative_array.size()',
substrs=[' = 3'])
self.expect('expr associative_array.count(hello_world)',
Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/unique-types/TestUniqueTypes.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/unique-types/TestUniqueTypes.py?rev=327463&r1=327462&r2=327463&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/unique-types/TestUniqueTypes.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/unique-types/TestUniqueTypes.py Tue Mar 13 16:37:11 2018
@@ -28,10 +28,6 @@ class UniqueTypesTestCase(TestBase):
compiler = self.getCompiler()
compiler_basename = os.path.basename(compiler)
- if "clang" in compiler_basename and int(
- self.getCompilerVersion().split('.')[0]) < 3:
- self.skipTest(
- "rdar://problem/9173060 lldb hangs while running unique-types for clang version < 3")
exe = self.getBuildArtifact("a.out")
self.runCmd("file " + exe, CURRENT_EXECUTABLE_SET)
Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/bitfield_ivars/TestBitfieldIvars.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/objc/bitfield_ivars/TestBitfieldIvars.py?rev=327463&r1=327462&r2=327463&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/lang/objc/bitfield_ivars/TestBitfieldIvars.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/lang/objc/bitfield_ivars/TestBitfieldIvars.py Tue Mar 13 16:37:11 2018
@@ -5,8 +5,8 @@ lldbinline.MakeInlineTest(
__file__,
globals(),
[
- decorators.skipIfFreeBSD,
- decorators.skipIfLinux,
- decorators.skipIfWindows,
+ # This is a Darwin-only failure related to incorrect expresssion-
+ # evaluation for single-bit ObjC bitfields.
+ decorators.skipUnlessDarwin,
decorators.expectedFailureAll(
bugnumber="rdar://problem/17990991")])
More information about the lldb-commits
mailing list