[Lldb-commits] [PATCH] D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687)

[Michał Górny via Phabricator via lldb-commits]

mgorny added inline comments.


================
Comment at: cmake/modules/LLDBConfig.cmake:354
+
+  check_library_exists(dl dlopen "" HAVE_LIBDL)
+  if (HAVE_LIBDL)
----------------
krytarowski wrote:
> A more portable form of this:
> 
> ```
> foreach(lib ${CMAKE_DL_LIBS})
> list(APPEND system_libs -l${lib})
> endforeach()
> ```
> 
> Haiku needs 2 libraries, other Unices can use `-lldl` or similar.
Didn't this raise the problem of cmake using full paths on some systems? 


https://reviews.llvm.org/D44379