[Lldb-commits] [PATCH] D44321: Support demangling for D symbols via dlopen

Sat Mar 10 17:07:58 PST 2018

davide added a comment.

In https://reviews.llvm.org/D44321#1034043, @timotheecour wrote:

> In https://reviews.llvm.org/D44321#1033325, @davide wrote:
>
> > This patch has no testcase. It shouldn't be particularly hard to write one, you can take inspiration from the one in `lit/`.
> >
> > Thanks!
>
>
> 5d29d3f0aa2f540c277a67eac5873feca8c62d51 (Support for OCaml native debugging) introduced a much larger change and had no test case either. If you really insist on a test case please provide more concrete guidance.

That was a while ago. In fact, the OCaml support is going to be removed. New languages need to meet an high(er) bar to be included. One of the requirements is, e.g. being tested.
It's a little more complicated for D because it's an out-of-tree compiler so it poses interesting challenges.
Let me think about it a little more and I'll come back to you.

Thanks,

-

Davide

https://reviews.llvm.org/D44321