[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

[Owen Shaw via Phabricator via lldb-commits]

owenpshaw updated this revision to Diff 137827.
owenpshaw added a comment.

Looking at LoadInMemory, it seems like the common code is actually more appropriate in the command handler.  It's checking inputs and doing the unrelated task of setting the pc.  So here's an attempt at going a little further to simplify ObjectFile and its dependencies

- Have the command check for a valid process, write to the process, and set the pc
- Replace ObjectFile::LoadInMemory with GetLoadableData
- Move/rename the Process::WriteEntry struct to ObjectFile::LoadableData

Thoughts?


https://reviews.llvm.org/D42145

Files:
  include/lldb/Core/Module.h
  include/lldb/Host/XML.h
  include/lldb/Symbol/ObjectFile.h
  include/lldb/Target/MemoryRegionInfo.h
  include/lldb/Target/Process.h
  packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestGDBRemoteLoad.py
  packages/Python/lldbsuite/test/functionalities/gdb_remote_client/gdbclientutils.py
  source/Commands/CommandObjectTarget.cpp
  source/Core/Module.cpp
  source/Host/common/XML.cpp
  source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
  source/Plugins/ObjectFile/ELF/ObjectFileELF.h
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
  source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
  source/Symbol/ObjectFile.cpp
  source/Target/Process.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42145.137827.patch
Type: text/x-patch
Size: 35956 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180309/40b1cab6/attachment-0001.bin>