[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions
Owen Shaw via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Mar 9 13:48:18 PST 2018
owenpshaw updated this revision to Diff 137827.
owenpshaw added a comment.
Looking at LoadInMemory, it seems like the common code is actually more appropriate in the command handler. It's checking inputs and doing the unrelated task of setting the pc. So here's an attempt at going a little further to simplify ObjectFile and its dependencies
- Have the command check for a valid process, write to the process, and set the pc
- Replace ObjectFile::LoadInMemory with GetLoadableData
- Move/rename the Process::WriteEntry struct to ObjectFile::LoadableData
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 35956 bytes
Desc: not available
More information about the lldb-commits