[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions
Owen Shaw via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Mar 9 08:13:59 PST 2018
owenpshaw added a comment.
It can be done that way. As I mentioned, it would require moving the Process.h import from ObjectFile.cpp to ObjectFile.h (to get the declaration of Process::WriteEntry). I'm asking how you guys feel about that. Without a clear sense of project norms, I'll always go for the less intrusive change, which in this case meant a slightly different signature instead of moving an import that wasn't necessary.
https://reviews.llvm.org/D42145
More information about the lldb-commits
mailing list