[Lldb-commits] [PATCH] D40475: DWZ 10/11: DWZ test mode

Jan Kratochvil via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Mar 8 11:56:11 PST 2018

jankratochvil added a comment.

In https://reviews.llvm.org/D40475#1018951, @davide wrote:

> fwiw, you don't need unit tests or python tests to implement this.
>  If I understand the feature correctly you can probably extend `lldb-test` (which is run as part of `check-lldb-lit`).

I do not understand much yet all the testing frameworks LLDB implements.  Could you suggest what you find redundant?  So far I do want to run the whole testsuite also in `dwz` mode.
I understand `unittests/SymbolFile/DWZ/SymbolFileDWZTests.cpp` could be written also as an extension of `tools/lldb-test`. But then I do not see why. The unit test of mine looks fine to me.


More information about the lldb-commits mailing list