[Lldb-commits] [PATCH] D44165: [SymbolFilePDB] Minor cleanup

Aaron Smith via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 6 19:17:26 PST 2018


asmith marked an inline comment as done.
asmith added inline comments.


================
Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:499
     auto type_list = GetTypeList();
-    type_list->Insert(result);
+    if (type_list)
+      type_list->Insert(result);
----------------
zturner wrote:
> Why would this return `nullptr`?
No idea but it does.

TypeList *Module::GetTypeList() {
  SymbolVendor *symbols = GetSymbolVendor();
  if (symbols)
    return &symbols->GetTypeList();
  return nullptr;
}


Repository:
  rL LLVM

https://reviews.llvm.org/D44165





More information about the lldb-commits mailing list