[Lldb-commits] [PATCH] D44041: Only replace object file sections when non-empty

[Pavel Labath via Phabricator via lldb-commits]

labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.

This looks like a perfect case for lldb-test. You will run into a couple of problems which will prevent this from working out of the box. I tried to fix those in https://reviews.llvm.org/D42955, but that turned into a major refactor. Until that CL lands, we should be able to make a quick hack in lldb-test which will make this testable:
The thing you will need to modify is to explicitly call module->GetSymbolVendor() before dumping out the sections (so that the symbol vendor populates these), and avoid setting the SymbolFileSpec on the ModuleSpec (so that the symbol vendor will find the external symbol file.


https://reviews.llvm.org/D44041