[Lldb-commits] [PATCH] D43912: [Symbol] Add InvalidType, a force-checked recoverable error

[Vedant Kumar via Phabricator via lldb-commits]

vsk updated this revision to Diff 136450.
vsk added a comment.

> The problem with your RETURN_IF_UNEXPECTED macro is that it make it impossible to put a breakpoint only on the "type was invalid case." To catch that happening while debugging you'd have to write a conditional breakpoint that also checks the error.

Yes, we'd need a conditional breakpoint if more than one InvalidTypeError instance is created (otherwise we'd just break on the constructor). While I hope we never have to deal with that, I'm happy to keep things more explicit for now.


https://reviews.llvm.org/D43912

Files:
  include/lldb/Symbol/CompilerType.h
  source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp
  source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.h
  source/Symbol/CompilerType.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43912.136450.patch
Type: text/x-patch
Size: 5710 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180301/0971b0f8/attachment-0001.bin>