[Lldb-commits] [PATCH] D43912: [Symbol] Add InvalidType, a force-checked recoverable error

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

The problem with your RETURN_IF_UNEXPECTED macro is that it make it impossible to put a breakpoint only on the "type was invalid case."  To catch that happening while debugging you'd have to write a conditional breakpoint that also checks the error.

That seems like something you would really want to be able to do.  If you leave the return outside the macro, then you can break on the return.  IMHO that's worth having to write

if (CHECK_IF_ERROR)

  return;


https://reviews.llvm.org/D43912