[Lldb-commits] [PATCH] D43837: Move option parsing out of the Args class

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

The separate gtest directories don't get build separately the way Todd set the Xcode project up.  The tests get built into one combo .a file that links to liblldbcore.a, and then into the test binary.  So the Xcode build wouldn't see that failure.

Since you are building .a files not dylibs from Utility, the UtilityTest won't show a failure for a class that has a dependency that the tests binary doesn't use, so this sort of thing could creep in.  Another reason to be vigilant about the test coverage.

Once your whole project is done, lldb-server shouldn't build if something it uses from Utility uses something not in Utility (or in some other .a file that lldb-server depends on).  That doesn't help altogether, since macOS only builds the platform part of lldb-server, so the macOS builds won't check usage in the other parts of lldb-server.  But the bots should be good enough.


https://reviews.llvm.org/D43837