[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

Right now, which tests are "run all variants" is represents more history than policy.  Opt out of all variants is opt in, and while I at least kick out obvious tests that don't really need to run all variants when I touch them, but I don't think we have done a careful audit.  I think the general idea of running variants is good, but we really should reduce the number of tests we run this way to the ones that actually test things that might break that way.

Note, I have (though very very occasionally) seen a dsymutil bug that broke line tables.  So it would be good to keep a few "set a breakpoint and run to it" tests just to sanity check this.  But most tests that just run somewhere and print a backtrace or view an integer variable or such-like do not need to run all variants.


https://reviews.llvm.org/D32167