[Lldb-commits] [PATCH] D43512: DWZ 11/11: Fix for symlinked .build-id/**.debug files
Jan Kratochvil via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Sat Feb 24 23:27:42 PST 2018
jankratochvil marked an inline comment as done.
jankratochvil added inline comments.
================
Comment at: source/Host/common/Symbols.cpp:288-290
if (llvm::sys::fs::equivalent(file_spec.GetPath(),
module_file_spec.GetPath()))
continue;
----------------
labath wrote:
> Do we need to check the equivalentness twice? My impression is that this function "sees through" symlinks (and even if it didn't, doing it post-resolve should be enough).
You are right, llvm::sys::fs::equivalent does `st_dev`+`st_ino` comparison.
https://reviews.llvm.org/D43512
More information about the lldb-commits
mailing list