[Lldb-commits] [PATCH] D39967: Disable breakpoints before writing memory and re-enable after.

[Tatyana Krasnukha via Phabricator via lldb-commits]

tatyana-krasnukha added inline comments.


================
Comment at: source/Target/Process.cpp:2437
+  for (auto &bp_site : enabled_bp_sites_in_range)
+    update_status(DisableSoftwareBreakpoint(bp_site.get()));
 
----------------
xiaobai wrote:
> If disabling any breakpoint fails, the status's error string will be "failed to re-enable one or more breakpoints". This is kind of confusing, imo.
Didn't found anything better than use word "update" here. Introducing additional flag looks ugly...

I hope, that this information is enough when user tries to write memory. More detailed description can be found in log.


https://reviews.llvm.org/D39967