[Lldb-commits] [PATCH] D43596: Replace HashStringUsingDJB with llvm::djbHash

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 22 07:57:54 PST 2018


JDevlieghere added a comment.

In https://reviews.llvm.org/D43596#1015848, @clayborg wrote:

> No need to add additional dSYM tests, because all dSYM tests will fail if the hashing isn't correct.


Maybe I misunderstand, but https://reviews.llvm.org/D42740 suggested that this never worked (or maybe it did accidentally, because we ended up in the right bucket) for unicode characters?


https://reviews.llvm.org/D43596





More information about the lldb-commits mailing list