[Lldb-commits] [PATCH] D40473: DWZ 10/12: Adjust existing code for the DWZ support.

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil added a subscriber: alexshap.
jankratochvil added inline comments.


================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp:199-202
+  if (die_ref.cu_offset == DW_INVALID_OFFSET
+      // FIXME: Workaround default cu_offset = 0 in DIERef ctor.
+      // Why does GetCompileUnit exist at all?
+      || (die_ref.cu_offset == 0 /* && m_dwarf2Data->GetDWZSymbolFile() */ ))
----------------
clayborg wrote:
> Just fix the DIERef constructor to not use 0 for the cu_offset?
This has been fixed in the meantime by @alexshap's D42563.



================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:388-390
+  // DIERef(DWARFFormValue)->DWARFFormValue::Reference() may need
+  // FileOffsetToUniqOffset.
+  dwarf2Data->PreloadSymbols();
----------------
clayborg wrote:
> This seems like the wrong place to do this call. We are asking all DWARF to index itself from DWARFDebugInfoEntry::GetDIENamesAndRanges()? Doesn't seem like the right place.
Fortunately it is somehow no longer needed now, dropped it.



https://reviews.llvm.org/D40473