[Lldb-commits] [PATCH] D43464: Avoid dirtying the source tree in breakpoint command tests

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.
labath added reviewers: jingham, aprantl.

The paralelization patch exposed a bunch of cases where we were still
touching the source tree (as these tests were now stepping on each
others toes and being flaky).

This patch removes such issues from breakpoint command tests. Since the
only reason they were creating files was to indirectly test whether the
breakpoint commands got executed (and plumbing the full build tree path
to all places that needed it would be messy) I decided to modify the
tests to check for a different side effect instead: modification of a
global variable. This also makes the code simpler as checking the value
of the global variable is easier, and there is nothing to clean up.

As the tests aren't really doing anything debug-info related, I took the
opportunity to also mark them as NO_DEBUG_INFO_TESTCASEs.


https://reviews.llvm.org/D43464

Files:
  packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py
  packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommandsFromPython.py
  packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/bktptcmd.py
  packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/side_effect.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43464.134908.patch
Type: text/x-patch
Size: 9776 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180219/325095fb/attachment.bin>