[Lldb-commits] [PATCH] D43333: Add SBDebugger::GetBuildConfiguration and use it to skip an XML test

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 15 11:11:09 PST 2018


clayborg added inline comments.


================
Comment at: source/API/SBDebugger.cpp:497
+  auto config_up = llvm::make_unique<StructuredData::Dictionary>();
+  config_up->AddBooleanItem("xml", XMLDocument::XMLEnabled());
+
----------------
Do we want a more self documenting format of the JSON? Maybe "xml" is a dictionary instead of just a value?

```
{ 
  "xml" : {
    "value" : true, 
    "description" : "A boolean value that indicates if XML support is enabled in LLDB" 
  }
}
```


https://reviews.llvm.org/D43333





More information about the lldb-commits mailing list