[Lldb-commits] [PATCH] D43215: Supply missing break in case statement.

Adrian McCarthy via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 14 09:50:27 PST 2018

amccarth updated this revision to Diff 134252.
amccarth added a comment.

Per Aaron's suggestion, I ran the tests with an unconditional return (and an assertion).  There was no change in the test results, so I'm making this return unconditionally.



Index: lldb/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp
--- lldb/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp
+++ lldb/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp
@@ -107,9 +107,7 @@
   case PDB_BuiltinType::None:
     return CompilerType();
   case PDB_BuiltinType::Void:
-    // FIXME: where is non-zero size of `void` from?
-    if (width == 0)
-      return clang_ast->GetBasicType(eBasicTypeVoid);
+    return clang_ast->GetBasicType(eBasicTypeVoid);
   case PDB_BuiltinType::Bool:
     return clang_ast->GetBasicType(eBasicTypeBool);
   case PDB_BuiltinType::Long:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43215.134252.patch
Type: text/x-patch
Size: 647 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180214/46ac8c52/attachment.bin>

More information about the lldb-commits mailing list