[Lldb-commits] [PATCH] D43292: [dotest] Add ability to skip tests based on build configuration

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 14 08:07:31 PST 2018


labath created this revision.
labath added reviewers: zturner, jingham, davide.
Herald added a subscriber: mgorny.

Some lldb features depend on xml support. Tests exercising that
functionality can only succeed if lldb was built with xml support. Right
now we have one such test, and another waiting in a patch that's blocked
on this.

This patch implements that functionality by exporting the build
configuration from cmake via configure_file (for the XCode build, I add
a hard-coded configuration file). Then, in dotest we parse this file and
use it to initialize a "feature" configuration variable. I chose a
fairly generic name as other as I anticipate adding other things here,
for example, the list of configured llvm targets. Lastly, I add a
new "features" option to the skipIf decorator enable skipping based on
configured features

The TestTargetXMLArch is updated to match on the xml feature instead of
incorrectly matching on the host platform.


https://reviews.llvm.org/D43292

Files:
  lldb.xcodeproj/lldb_build_config.py
  packages/Python/lldbsuite/test/configuration.py
  packages/Python/lldbsuite/test/decorators.py
  packages/Python/lldbsuite/test/dotest.py
  packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestTargetXMLArch.py
  test/CMakeLists.txt
  test/lldb_build_config.py.in

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43292.134229.patch
Type: text/x-patch
Size: 7721 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180214/55379bb0/attachment.bin>


More information about the lldb-commits mailing list