[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Feb 12 07:33:24 PST 2018


clayborg added inline comments.
Herald added a subscriber: arichardson.


================
Comment at: source/Core/Module.cpp:1286
+    if (SymbolVendor *vendor = GetSymbolVendor())
+      vendor->CreateSections(*GetUnifiedSectionList());
   }
----------------
should we pass "obj_file" down into the SymbolVendor::CreateSections(...) call for the case where the symbol vendor is using the same ObjectFile that it can just return?


https://reviews.llvm.org/D42955





More information about the lldb-commits mailing list