[Lldb-commits] [PATCH] D43096: [lit] Update how clang and other binaries are found in per-configuration directories

Zachary Turner via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 8 16:15:55 PST 2018

zturner added inline comments.

Comment at: lit/CMakeLists.txt:10-13
This only works if you're using a just-built clang, which might not be the case.  In fact, it's usually not the case, because it's common to want to run the test suite against a debug build of lldb but using a release build of clang (otherwise you'll be there all day waiting for it to finish).

I feel like if the user specifies an absolute path to the test compiler on the command line, that should be what it uses -- always.  If we want to use a just built toolchain, maybe we need something else, like `-DLLDB_TEST_BUILT_CLANG=ON`, which would trigger this logic.

As I don't use this configuration though, I'm interested in hearing your thoughts.


More information about the lldb-commits mailing list