[Lldb-commits] [PATCH] D42994: Only throw -fPIC when building a shared library

Zachary Turner via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 8 13:54:25 PST 2018

zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.

This lgtm.  If this causes some tests that were previously skipped or xfailed to start passing, you can unskip / unxfail them at the same time.

Comment at: packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py:49
-        except OSError, e:
+        except OSError as e:
             if e.errno != os.errno.EEXIST:
Weird, does that comma syntax even do anything or was that just a bug?



More information about the lldb-commits mailing list