[Lldb-commits] [PATCH] D43059: Add implementation for MSVC in CPlusPlusLanguage::IsCPPMangledName

[Zachary Turner via lldb-commits]

I think just remove the preprocessor block. Imagine debugging a Windows
target from a linux host. This function would return false as written
because the host wasn’t Windows
On Thu, Feb 8, 2018 at 12:18 PM Aaron Smith via Phabricator <
reviews at reviews.llvm.org> wrote:

> asmith added a comment.
>
> IsCPPMangledName() is a public method to determine if a symbol has a
> mangled name.
>
> This change is needed so that lldb can find symbols with MSVC style
> mangled names.
>
> Open to suggestions on a better way to deal with this...
>
> Here are all the places it is used:
>
> source/Core/Module.cpp:    if
> (CPlusPlusLanguage::IsCPPMangledName(name_cstr))
> source/Core/Module.cpp:
> !CPlusPlusLanguage::IsCPPMangledName(name_cstr)) {
> source/Core/Mangled.cpp:      if
> (CPlusPlusLanguage::IsCPPMangledName(mangled_name))
> source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp:
>                  !CPlusPlusLanguage::IsCPPMangledName(name)) ||
> source/Expression/IRExecutionUnit.cpp:    if
> (CPlusPlusLanguage::IsCPPMangledName(name.GetCString())) {
> source/Expression/IRExecutionUnit.cpp:    if
> (CPlusPlusLanguage::IsCPPMangledName(name.GetCString())) {
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D43059
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180208/6f215f57/attachment.html>