[Lldb-commits] [PATCH] D42994: Stop passing -fPIC to lldb tests on Windows

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:550
 #----------------------------------------------------------------------
 $(DYLIB_OBJECTS) : CFLAGS += -DCOMPILING_LLDB_TEST_DLL
 
----------------
I think Zachary meant only when building the shared library, but you're doing it unconditionally. This would be a nice place to set the flag for shared library only.


https://reviews.llvm.org/D42994