[Lldb-commits] [PATCH] D43059: Add implementation for MSVC in CPlusPlusLanguage::IsCPPMangledName

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 8 01:47:05 PST 2018

labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.

That seems extremely dodgy. Surely whether something is a mangled name does not depend on the compiler we built lldb with. I am aware that we have many places with _Z hardcoded, but this seems to be making the situation only worse.

I'm not sure how is this API being used, but maybe this should just recognize both mangling schemes unconditionally ?



More information about the lldb-commits mailing list