[Lldb-commits] [lldb] r322339 - When parsing the target.xml register file, if no architecture has

[Davide Italiano via lldb-commits]

ping. I might consider reverting this and the other commits without
tests bay the end of the week unless we have a story for testing here.
It's been one month.

On Mon, Feb 5, 2018 at 9:44 AM, Davide Italiano <dccitaliano at gmail.com> wrote:
> On Mon, Jan 29, 2018 at 10:17 AM, Jason Molenda <jmolenda at apple.com> wrote:
>>
>>
>>> On Jan 28, 2018, at 9:59 PM, Davide Italiano <dccitaliano at gmail.com> wrote:
>>>
>>> On Thu, Jan 11, 2018 at 5:26 PM, Davide Italiano <dccitaliano at gmail.com> wrote:
>>>> On Thu, Jan 11, 2018 at 5:16 PM, Jason Molenda via lldb-commits
>>>> <lldb-commits at lists.llvm.org> wrote:
>>>>> Author: jmolenda
>>>>> Date: Thu Jan 11 17:16:13 2018
>>>>> New Revision: 322339
>>>>>
>>>>> URL: http://llvm.org/viewvc/llvm-project?rev=322339&view=rev
>>>>> Log:
>>>>> When parsing the target.xml register file, if no architecture has
>>>>> been specified yet (either by the user, or by one of the lldb
>>>>> extensions like qHostInfo or qProcessInfo), and the target.xml
>>>>> includes a <architecture> tag specifying x86_64, set the architecture
>>>>> appropriately.
>>>>>
>>>>> I'm not sure what we can expect to see in the <architecture> tag, so
>>>>> I'm only doing this for x86_64 right now where I've seen "i386:x86_64"
>>>>> used.  I've seen a target.xml from a jtag board that sends just "arm"
>>>>> because it doesn't know more specifically what type of board it is
>>>>> connected to...
>>>>>
>>>>> <rdar://problem/29908970>
>>>>>
>>>>
>>>> Jason,
>>>> is there a way to test this change?
>>>>
>>>
>>> ping? Any news on this front?
>>
>> Thanks for the reminder.  I need to look at doing this - I'm in the middle of another patch right now but I'll return to this after that.
>
> weekly ping :)
>
> --
> Davide