[Lldb-commits] [PATCH] D42931: ELF GetSectionHeaderInfo: process SHT_NOTE even without .shstrtab

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Feb 6 02:31:05 PST 2018

labath added a comment.

As I mentioned in the patch above, I don't think it's worth it trying to tiptoe here, as for 99% of files (basically, anything that is not yaml2obj's output, I think), we will end up reading the whole file anyway. It just increases the number of things that can go wrong.

It might be interesting to make GetModuleSpecifications access only the smallest number of bytes as possible, but for that we should make a larger patch that changes the entire parsing logic.


More information about the lldb-commits mailing list