[Lldb-commits] [PATCH] D42939: More correct handling of error cases C++ name parser

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Feb 6 01:59:37 PST 2018

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Being more resilient when handling demangler outputs seems like a good thing, but I think it is important to understand what made the demangler produce that output in the first place, to make sure we aren't missing anything.

Also, I think I found one more possible issue with this code.

Comment at: source/Plugins/Language/CPlusPlus/CPlusPlusNameParser.cpp:199
     case tok::greatergreater:
       template_counter -= 2;
       can_open_template = false;
While looking at the bug, this part here struck me as dubious.

Can you check that this properly handles a name like `F<(3)>>(1)> f<3, 1>()` (which is the demangled form of _Z1fILi3ELi1EE1FIXrsT_T0_EEv).


More information about the lldb-commits mailing list