[Lldb-commits] [PATCH] D42908: Fix Bug 36237 - TestTargetSymbolsSepDebugSymlink fails when run remotely

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Feb 5 07:47:11 PST 2018

labath added a comment.

>> I think that a more reasonable behavior here would be to copy the file contents instead.

> The symlink is essential for this testcase otherwise it does not test the bugfix. OK to just disable it for remote testing?

My comment you are quoting should applies to Platform::Install, not your test. I don't think there's anything special you should need to do in the test to make this work remotely. However, trying to copy a symlink to a remote system and expecting it will make sense there does not sound like a reasonable thing to do. That's why I created that bug, as I think it exposes a bug on our side (i.e. debugging a symlinked executable remotely will just not work).

I already added this decorator, so you can drop this diff. It would be ideal if the test worked remotely as well, but it seems the test fails due to reasons which are completely outside of the scope of your original patch.

Btw, you are right that the symlink does get created -- I was looking at the wrong implementation of CreateSymlink(). I'll update the bug accordingly.


More information about the lldb-commits mailing list