[Lldb-commits] [PATCH] D42853: Resolve binary symlinks before finding its separate .debug file

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.

Looks fine, just a couple of tweaks to the test case. No need to wait for another round of review.



================
Comment at: packages/Python/lldbsuite/test/linux/sepdebugsymlink/TestTargetSymbolsSepDebugSymlink.py:17
+        TestBase.setUp(self)
+        self.source = 'main.c'
+
----------------
`source` seems to be unused (and after that you can also remove the `setUp` function).


================
Comment at: packages/Python/lldbsuite/test/linux/sepdebugsymlink/TestTargetSymbolsSepDebugSymlink.py:20
+    @no_debug_info_test  # Prevent the genaration of the dwarf version of this test
+    @skipUnlessPlatform(['linux'])
+    def test_target_symbols_sepdebug_symlink_case(self):
----------------
Please add something like `skipIf(hostoslist=["windows"])` here. (The point being that the symlink creation will not work when doing remote debugging from windows).


https://reviews.llvm.org/D42853