[Lldb-commits] [PATCH] D42443: [SymbolFilePDB] Add support for function symbols

[Pavel Labath via lldb-commits]

Well... it would be *very*-nice-to-have thing. I would very much love
to be able to run at least one pdb test from linux. (So, I'm not
opposing this in any way, just pointing out what needs to happen).

On 1 February 2018 at 18:35, Zachary Turner <zturner at google.com> wrote:
> Yea good point. We can probably punt on this for now as it’s just a
> nice-to-have
>
> On Thu, Feb 1, 2018 at 1:38 AM Pavel Labath via Phabricator
> <reviews at reviews.llvm.org> wrote:
>>
>> labath added inline comments.
>>
>>
>> ================
>> Comment at: lit/SymbolFile/PDB/func-symbols.test:4
>> +RUN: clang-cl -m32 /Z7 /c /GS- %S/Inputs/FuncSymbols.cpp /o
>> %T/FuncSymbols.cpp.obj
>> +RUN: link %T/FuncSymbolsTestMain.cpp.obj %T/FuncSymbols.cpp.obj /DEBUG
>> /nodefaultlib /Entry:main /OUT:%T/FuncSymbolsTest.exe
>> +RUN: lldb-test symbols %T/FuncSymbolsTest.exe | FileCheck %s
>> ----------------
>> zturner wrote:
>> > I bet we could get rid of `REQUIRES: windows` if we changed this to
>> > `lld-link`.  You're already specifying `/nodefaultlib /entry:main`, and no
>> > windows header files are included, so maybe it's worth a try?
>> That would be great, but you'd probably still need something like
>> REQUIRES:lld, as lld is not currently not a mandatory requirement for
>> building/testing.
>>
>>
>> Repository:
>>   rL LLVM
>>
>> https://reviews.llvm.org/D42443
>>
>>
>>
>