[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

[Adrian Prantl via Phabricator via lldb-commits]

aprantl created this revision.
aprantl added reviewers: labath, zturner, jingham.
Herald added subscribers: JDevlieghere, eraman.

This patch creates a <test>.dwarf, <test>.dwo, etc., build directory for each testcase variant.
Most importantly, this eliminates the need for the per-test lock file in the source directory.

Tests that are marked as NO_DEBUG_INFO_TESTCASE and build with buildDefault() are built in a <test>.default build directory.

The implementation changes self.mydir to a tuple (test_subdir, test_name). I chose not to rename the variable as to not break anyone's out-of-tree testcases any more than necessary.

It would be awesome if someone could test this on Windows / Linux / Android again.


https://reviews.llvm.org/D42763

Files:
  packages/Python/lldbsuite/test/api/listeners/TestListener.py
  packages/Python/lldbsuite/test/functionalities/breakpoint/comp_dir_symlink/TestCompDirSymLink.py
  packages/Python/lldbsuite/test/functionalities/load_unload/TestLoadUnload.py
  packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_on_vectors/TestValueOfVectorVariable.py
  packages/Python/lldbsuite/test/lldbinline.py
  packages/Python/lldbsuite/test/lldbtest.py
  packages/Python/lldbsuite/test/plugins/builder_base.py
  packages/Python/lldbsuite/test/plugins/builder_darwin.py
  packages/Python/lldbsuite/test/python_api/hello_world/TestHelloWorld.py
  packages/Python/lldbsuite/test/python_api/process/io/TestProcessIO.py
  packages/Python/lldbsuite/test/python_api/symbol-context/TestSymbolContext.py
  packages/Python/lldbsuite/test/python_api/value_var_update/TestValueVarUpdate.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42763.132267.patch
Type: text/x-patch
Size: 26532 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180131/96dac622/attachment-0001.bin>