[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 30 02:01:44 PST 2018


labath added a comment.

I still like my `WriteMemory(ArrayRef<MemoryWriteDescriptor>)` proposal the best. If you don't have any special writing requirements, it can be viewed as a convenience wrapper for the one-shot `WriteMemory`, and if a subclass needs special handling, it can implement it in a smarter way (while making sure that the one-shot call still "does the right thing", just in a slower way).

It also makes it impossible to forget to call `EndBatch()`.


https://reviews.llvm.org/D42145





More information about the lldb-commits mailing list