[Lldb-commits] [PATCH] D42281: Compile the LLDB tests out-of-tree

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

In https://reviews.llvm.org/D42281#989793, @aprantl wrote:

> I am now working on building each test variant (dwarf,dwo,dsym,...) in its own build directory so they can run in parallel and we can get rid of the lockfile.


Are you planning to merge that into this patch? I am hoping that can be done in a separate pass, once dust settles down from landing this batch.

I think this is in a pretty good shape now, and we should land it soon. The only thing i'd like to wait for is confirmation that this runs on windows (i.e. does not run into any fundamental make limitations on that platform). I'm going to see if I can get around to that today.



================
Comment at: packages/Python/lldbsuite/test/functionalities/exec/TestExec.py:47
         if self.getArchitecture() == 'x86_64':
-            source = os.path.join(os.getcwd(), "main.cpp")
-            o_file = os.path.join(os.getcwd(), "main.o")
+            source = self.getSourcPath("main.cpp")
+            o_file = self.getBuildArtifact("main.o")
----------------
s/Sourc/Source/


================
Comment at: packages/Python/lldbsuite/test/plugins/builder_base.py:65
+            (not os.path.isabs(rel_testdir))):
+        #import pdb; pdb.set_trace()
+        raise Exception("Could not derive test directories")
----------------
delete


================
Comment at: source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:5139-5142
-        if (file_spec.Exists() && files.AppendIfUnique(file_spec)) {
+        if (file_spec.Exists() && files.AppendIfUnique(file_spec))
           count++;
-          break;
-        }
----------------
I think it makes sense to separate the single change in actual code from the gigantuous code refactor.


https://reviews.llvm.org/D42281