[Lldb-commits] [lldb] r323467 - [test] Fix a test that never compiled under -fmodules

Vedant Kumar via lldb-commits lldb-commits at lists.llvm.org
Thu Jan 25 13:20:29 PST 2018


Author: vedantk
Date: Thu Jan 25 13:20:29 2018
New Revision: 323467

URL: http://llvm.org/viewvc/llvm-project?rev=323467&view=rev
Log:
[test] Fix a test that never compiled under -fmodules

This test #include's stdio.h, which, on at least two bots results in a
module import of MacTypes.h (due to weird SDK layering issues), which
causes the test to fail to compile.

Just don't #include stdio.h, as it's not needed for the test.

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/functionalities/non-overlapping-index-variable-i/main.cpp

Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/non-overlapping-index-variable-i/main.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/non-overlapping-index-variable-i/main.cpp?rev=323467&r1=323466&r2=323467&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/functionalities/non-overlapping-index-variable-i/main.cpp (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/non-overlapping-index-variable-i/main.cpp Thu Jan 25 13:20:29 2018
@@ -6,7 +6,6 @@
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
-#include <stdio.h>
 
 class Point {
 public:
@@ -37,15 +36,11 @@ int main(int argc, char const *argv[]) {
         ptr[i]->point.y = i+1;
     }
 
-    printf("Finished populating data.\n");
     for (int i = 0; i < 1000; ++i) {
         bool dump = argc > 1; // Set breakpoint here.
                               // Evaluate a couple of expressions (2*1000 = 2000 exprs):
                               // expr ptr[i]->point.x
                               // expr ptr[i]->point.y
-        if (dump) {
-            printf("data[%d] = %d (%d, %d)\n", i, ptr[i]->id, ptr[i]->point.x, ptr[i]->point.y);
-        }
     }
     return 0;
 }




More information about the lldb-commits mailing list