[Lldb-commits] [PATCH] D42488: Remove ObjectFile usage from HostLinux::GetProcessInfo

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jan 24 12:00:02 PST 2018


labath planned changes to this revision.
labath added inline comments.


================
Comment at: source/Host/linux/Host.cpp:129
+  auto buffer_sp = DataBufferLLVM::CreateSliceFromPath(exe_path, 0x20, 0);
+  if (buffer_sp)
+    return ArchSpec();
----------------
eugene wrote:
> Shouldn't it be
> 
> ```
> if (!buffer_sp)
> ```
> 
> ?
Indeed it should. Thanks.
I'll have to figure out tomorrow why the test still passed... :/


https://reviews.llvm.org/D42488





More information about the lldb-commits mailing list