[Lldb-commits] [PATCH] D42277: Use test-specific module caches to avoid stale header conflicts

[Vedant Kumar via Phabricator via lldb-commits]

vsk added a comment.

In https://reviews.llvm.org/D42277#985002, @aprantl wrote:

> > Skip tests which fail when -fmodules is passed (https://bugs.llvm.org/show_bug.cgi?id=36048).
>
> Wait.. this patch is not supposed to change the set of tests that get -fmodules passed to them. It should only add -fmodules-cache-path to tests that do pass -fmodules. Why is this necessary?


It's not necessary, but we should make this change. It falls out of removing this FIXME:

  # FIXME: C++ modules aren't supported on all platforms.
  CXXFLAGS += $(subst -fmodules,, $(CFLAGS))

If we keep it around, we'd need an extra hack to strip out "-fmodules-cache-path=module-cache" as well. Without that we'd pass "-cache-path=module-cache", which clang would reject.

Another benefit of making this change is that it lets us know which tests are actually failing with modules enabled, instead of hiding them.


https://reviews.llvm.org/D42277