[Lldb-commits] [PATCH] D39967: Refactoring of MemoryWrite function

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

In https://reviews.llvm.org/D39967#985171, @clayborg wrote:

> That would be an easy fix for the ObjectFile::Load(), we could see if there are any breakpoints in the range we are trying to write, get a list of them, disable them all, write memory and re-enable. But this doesn't stop a user from trying doing something like:
>
>   (lldb) script lldb.process.WriteMemory(...)
>
>
> And they should expect this to just work no matter where they write memory.


Couldn't WriteMemory do the same thing as well? I would expect that 99% of WriteMemory calls will not intersect any breakpoints so the overhead of disabling and re-enabling should be negligible.


https://reviews.llvm.org/D39967