[Lldb-commits] [PATCH] D42195: [lldb] Generic base for testing gdb-remote behavior

[Jim Ingham via lldb-commits]

> On Jan 22, 2018, at 3:10 AM, Pavel Labath via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> labath added subscribers: krytarowski, jingham, davide.
> labath added a comment.
> 
> In https://reviews.llvm.org/D42195#982035, @owenpshaw wrote:
> 
>> - Added yaml2obj dependency.  It it okay to be an unconditional dependency?
> 
> 
> Yeah, it probably needs to be conditional (if(TARGET yaml2obj)), because standalone builds will not have that target. OTOH, standalone builds will probably also have an issue with finding yaml2obj. However, I don't think it should be up to you to make standalone builds work. cc'ing Kamil and Michal, as they are the ones who use those builds.
> 
> What I am not sure about is whether we need to make any changes to accomodate the XCode build. Jim, Davide: What would it take to make a test like this work from xcode?

Sorry, I haven't been following.  These seem like standard lldb-unittest2 type tests.  What is the difficultly of getting such a test to run from Xcode?

Jim


> 
>> - I can put the socket close() back in, but had removed it because python should close it automatically on garbage collection, so it didn't seem to matter either way
> 
> Yes, please put it back. There's no telling when GC will happen, so we shouldn't be holding onto relatively scarce os resources waiting for that...
> 
> 
> https://reviews.llvm.org/D42195
> 
> 
>