[Lldb-commits] [PATCH] D40283: lldb: Use the DWARF linkage name when importing C++ methods

[Davide Italiano via Phabricator via lldb-commits]

davide added a comment.

In https://reviews.llvm.org/D40283#983057, @nelhage wrote:

> I did a little bit of looking into performance implications today. It looks like `DWARFASTParserClang::ParseTypeFromDWARF` is only called lazily as symbols are needed, which alleviates some of my concerns, and also makes it a bit trickier to construct a convenient benchmark. Does someone with performance concerns have a specific usage pattern or operation or mode that they're concerned by the performance of for me to dig into?


My take is that we should consider going ahead with this. I tried and I confirm your experience (basically std::string in libstdc++ is undebbuggable).
Please wait a couple of days in case somebody has comments otherwise I'd say this can go in. BTW, do you need somebody to commit this on your behalf?

Thanks!

-

Davide


https://reviews.llvm.org/D40283