[Lldb-commits] [PATCH] D42280: Wrap all references to build artifacts in the LLDB testsuite in TestBase::getBuildArtifact()

[Vedant Kumar via Phabricator via lldb-commits]

vsk added a comment.

In https://reviews.llvm.org/D42280#982190, @jingham wrote:

> We have a lot of ugly boilerplate in the testsuite.  I added:
>
>   (target, process, thread, bkpt) = lldbutil.run_to_source_breakpoint(self,
>                              "Set a breakpoint here", self.main_source_file)
>   
>
> Because that's what a lot of tests did.  I converted a handful of tests and then ran out of time.
>
> If we're going to touch how all the tests get started with their executable it would be nice to see how many of them can be easily converted to this interface.  I can also add a file & line version of this, though in fact most tests that use file & line breakpoints actually use a source match to get a line number and then feed the line to lldb, so they could easily be converted to this.
>
> Then all the business of locating the binary could be centralized.
>
> I guess it's a little late for this comment, however...


I think lldbutil.run_to_source_breakpoint is definitely worth standardizing on, but as it stands, this patch lgtm as an initial step.


https://reviews.llvm.org/D42280