[Lldb-commits] [PATCH] D42281: WIP: compile the LLDB tests out-of-tree

Davide Italiano via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jan 19 09:10:18 PST 2018


davide requested changes to this revision.
davide added a comment.
This revision now requires changes to proceed.

This looks like a decent way of going forward, I'm a little concerned about swallowing an error, see comment inline.



================
Comment at: packages/Python/lldbsuite/test/dotest.py:1196
+        try: os.makedirs(configuration.test_build_dir, 448)
+        except: pass
+    else:
----------------
should we actually print some warning here? (e.g. directory `blah/` already exists?)


https://reviews.llvm.org/D42281





More information about the lldb-commits mailing list