[Lldb-commits] [PATCH] D42277: Use test-specific module caches to avoid stale header conflicts

[Vedant Kumar via Phabricator via lldb-commits]

vsk added inline comments.


================
Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:240
 
+CLANG_MODULE_CACHE_DIR := module-cache
+
----------------
aprantl wrote:
> Is it safe that this is a relative path?
I admit it's not great, but it's at least in keeping with the other targets we define in this Makefile (like a.out, the dsym, etc). As I'm writing this, I've realized I did not upload a diff with context, so this might not have been apparent!


================
Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:242
+
+MANDATORY_MODULE_BUILD_CFLAGS := -fmodules -fmodules-cache-path=$(CLANG_MODULE_CACHE_DIR)
+
----------------
aprantl wrote:
> Should we also specify `-fcxxmodules` here? Or will that break some bots with older clangs?
I've tried to avoid changing the flags used by each Makefile when possible. The only exception is my removal of "$(subst -fmodules,, $(CFLAGS))" in CXXFLAGS, which I needed to do because the substitution would make us pass "-cache-path=foo".

We might consider adding in -fcxxmodules as a followup (maybe just in CXXFLAGS?).


https://reviews.llvm.org/D42277