[Lldb-commits] [lldb] r322472 - Fix HostInfoBase::ComputeSharedLibraryDirectory comment

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Mon Jan 15 01:56:00 PST 2018


Author: labath
Date: Mon Jan 15 01:56:00 2018
New Revision: 322472

URL: http://llvm.org/viewvc/llvm-project?rev=322472&view=rev
Log:
Fix HostInfoBase::ComputeSharedLibraryDirectory comment

The comment seems to indicate that this function would return the "bin"
directory on linux. I've verified that this is not the case, so I'm
updating the comment to match.

Modified:
    lldb/trunk/source/Host/common/HostInfoBase.cpp

Modified: lldb/trunk/source/Host/common/HostInfoBase.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/HostInfoBase.cpp?rev=322472&r1=322471&r2=322472&view=diff
==============================================================================
--- lldb/trunk/source/Host/common/HostInfoBase.cpp (original)
+++ lldb/trunk/source/Host/common/HostInfoBase.cpp Mon Jan 15 01:56:00 2018
@@ -282,10 +282,8 @@ ArchSpec HostInfoBase::GetAugmentedArchS
 
 bool HostInfoBase::ComputeSharedLibraryDirectory(FileSpec &file_spec) {
   // To get paths related to LLDB we get the path to the executable that
-  // contains this function. On MacOSX this will be "LLDB.framework/.../LLDB",
-  // on linux this is assumed to be the "lldb" main executable. If LLDB on
-  // linux is actually in a shared library (liblldb.so) then this function will
-  // need to be modified to "do the right thing".
+  // contains this function. On MacOSX this will be "LLDB.framework/.../LLDB".
+  // On other posix systems, we will get .../lib(64|32)?/liblldb.so.
 
   FileSpec lldb_file_spec(
       Host::GetModuleFileSpecForHostAddress(reinterpret_cast<void *>(




More information about the lldb-commits mailing list